Skip to content

Commit 51c8842

Browse files
Jinjie RuanPaolo Abeni
authored andcommitted
net: dsa: realtek: Use for_each_child_of_node_scoped()
Avoid need to manually handle of_node_put() by using for_each_child_of_node_scoped(), which can simplfy code. Reviewed-by: Andrew Lunn <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: Jinjie Ruan <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 81b4eb6 commit 51c8842

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/net/dsa/realtek/rtl8366rb.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,8 +1009,8 @@ static int rtl8366rb_setup_all_leds_off(struct realtek_priv *priv)
10091009

10101010
static int rtl8366rb_setup_leds(struct realtek_priv *priv)
10111011
{
1012-
struct device_node *leds_np, *led_np;
10131012
struct dsa_switch *ds = &priv->ds;
1013+
struct device_node *leds_np;
10141014
struct dsa_port *dp;
10151015
int ret = 0;
10161016

@@ -1025,13 +1025,11 @@ static int rtl8366rb_setup_leds(struct realtek_priv *priv)
10251025
continue;
10261026
}
10271027

1028-
for_each_child_of_node(leds_np, led_np) {
1028+
for_each_child_of_node_scoped(leds_np, led_np) {
10291029
ret = rtl8366rb_setup_led(priv, dp,
10301030
of_fwnode_handle(led_np));
1031-
if (ret) {
1032-
of_node_put(led_np);
1031+
if (ret)
10331032
break;
1034-
}
10351033
}
10361034

10371035
of_node_put(leds_np);

0 commit comments

Comments
 (0)