Skip to content

Do not perform superfluous bounds checks on dropping crossbeam-epoch::Bag #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Oct 27, 2019
+3 −3
Merged

Do not perform superfluous bounds checks on dropping crossbeam-epoch::Bag #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crossbeam-epoch/src/internal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ impl Default for Bag {
impl Drop for Bag {
fn drop(&mut self) {
// Call all deferred functions.
for i in 0..self.len {
for deferred in &mut self.deferreds[..self.len] {
let no_op = Deferred::new(no_op_func);
let deferred = mem::replace(&mut self.deferreds[i], no_op);
deferred.call();
let owned_deferred = mem::replace(deferred, no_op);
owned_deferred.call();
}
}
}
Expand Down