freebsd: include memstat in build image #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
approved these changes
Dec 4, 2022
Member
Emilgardis
left a comment
Emilgardis
left a comment
There was a problem hiding this comment.
awesome!
Do you think this needs a changelog entry? I'm fine without one
Contributor
Author
|
Added a changelog entry for this PR. |
Contributor
|
Build succeeded: |
sunshowers
added a commit
to nextest-rs/nextest
that referenced
this pull request
Dec 11, 2022
This image includes a fix for cross-rs/cross#1166.
svenstaro
added a commit
to svenstaro/miniserve
that referenced
this pull request
Jan 1, 2023
svenstaro
added a commit
to svenstaro/genact
that referenced
this pull request
Jan 2, 2023
svenstaro
added a commit
to svenstaro/site24x7_exporter
that referenced
this pull request
Jan 6, 2023
Merged
bors bot
added a commit
that referenced
this pull request
Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis See #962 (comment) includes ee3c972 #962 fc3df66 #1166 33ee940 in #997 81c1e59 #950 6a57d01 #1183 Co-authored-by: Emil Gardström <[email protected]> Co-authored-by: Alex Huszagh <[email protected]> Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 4, 2023
1201: Release v0.2.5 r=Emilgardis a=Emilgardis See #962 (comment) includes ee3c972 #962 fc3df66 #1166 33ee940 in #997 81c1e59 #950 6a57d01 #1183 Co-authored-by: Emil Gardström <[email protected]> Co-authored-by: Alex Huszagh <[email protected]> Co-authored-by: Taiki Endo <[email protected]>
maltekrupa
added a commit
to maltekrupa/explorer
that referenced
this pull request
Jun 15, 2023
The default is cross 0.2.4 which was created in Juli of 2022 [0]. The patch to add libmemstat [1] was created in December of 2022, so we need a newer version of cross. [0] https://github.com/cross-rs/cross/pkgs/container/x86_64-unknown-freebsd/28076628?tag=0.2.4 [1] cross-rs/cross#1166
maltekrupa
added a commit
to maltekrupa/explorer
that referenced
this pull request
Jun 15, 2023
The default is cross v0.2.4 which was created in Juli of 2022 [0]. The patch to add libmemstat [1] was created in December of 2022, so we need a newer version of cross. [0] https://github.com/cross-rs/cross/pkgs/container/x86_64-unknown-freebsd/28076628?tag=0.2.4 [1] cross-rs/cross#1166
philss
pushed a commit
to elixir-explorer/explorer
that referenced
this pull request
Jun 19, 2023
* Add freebsd as target for precomp NIFs * Use existing target * Use ubuntu as OS and make use of cross * Set cross version to v0.2.5 The default is cross v0.2.4 which was created in Juli of 2022 [0]. The patch to add libmemstat [1] was created in December of 2022, so we need a newer version of cross. [0] https://github.com/cross-rs/cross/pkgs/container/x86_64-unknown-freebsd/28076628?tag=0.2.4 [1] cross-rs/cross#1166 * Use ubuntu-22.04 for freebsd target * Re-enable all disabled targets * Use ubuntu-22.04 for all cross based targets * Revert to use ubuntu-20.04 for existing targets This introduces a new variable `cross-version` which defaults to v0.2.4 and is set to v0.2.5 for freebsd. It is required because cross v0.2.5 fails to build on ubuntu-20.04. * Add freebsd to list of targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libc 0.2.138 added memstat_* functions, but the build with cross fails because the build image does not contain the corresponding library. See rust-lang/libc#3025 for more context. See also rust-lang/rust#105222 which is the same fix to rust-lang/rust's build image.