Add inverse_of to has_many :messages #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly specify the inverse_of messages relationship because the foreign_key attribute is set. Add spec to confirm the change. This seems to be required by active record as described here: https://guides.rubyonrails.org/association_basics.html#bi-directional-associations > Due to the :foreign_key option, Active Record will not automatically recognize the bi-directional association, which can lead to several issues: > ... > By including the :inverse_of option in the has_many association declaration, Active Record will recognize the bi-directional association and behave as described in the initial examples above.
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 89.92% 89.87% -0.06%
==========================================
Files 75 75
Lines 2800 2776 -24
Branches 549 543 -6
==========================================
- Hits 2518 2495 -23
+ Misses 282 281 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
parruda
pushed a commit
to parruda/ruby_llm
that referenced
this pull request
Nov 18, 2025
## What this does Explicitly specify the `inverse_of` messages relationship because the `foreign_key` attribute is set since [v.1.3.0](crmne/ruby_llm@1.2.0...1.3.0) This seems to be required by active record as described in the [rails guides page on associations](https://guides.rubyonrails.org/association_basics.html#bi-directional-associations) > Due to the :foreign_key option, Active Record will not automatically recognize the bi-directional association, which can lead to several issues: > ... > By including the :inverse_of option in the has_many association declaration, Active Record will recognize the bi-directional association and behave as described in the initial examples above. ## Type of change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation - [ ] Performance improvement ## Scope check - [x] I read the [Contributing Guide](https://github.com/crmne/ruby_llm/blob/main/CONTRIBUTING.md) - [x] This aligns with RubyLLM's focus on **LLM communication** - [x] This isn't application-specific logic that belongs in user code - [x] This benefits most users, not just my specific use case ## Quality check - [x] I ran `overcommit --install` and all hooks pass - [x] I tested my changes thoroughly - [x] I updated documentation if needed - [x] I didn't modify auto-generated files manually (`models.json`, `aliases.json`) ## API changes - [ ] Breaking change - [ ] New public methods/classes - [ ] Changed method signatures - [x] No API changes ## Related issues <!-- Link issues: "Fixes crmne#123" or "Related to crmne#123" --> Co-authored-by: Carmine Paolino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Explicitly specify the
inverse_ofmessages relationship because theforeign_keyattribute is set since v.1.3.0This seems to be required by active record as described in the rails guides page on associations
Type of change
Scope check
Quality check
overcommit --installand all hooks passmodels.json,aliases.json)API changes
Related issues