update check for user in hyper-v admins group

this adds additional check to figure out if the user is a domained joined
by looking at the value of env variables COMPUTERNAME and DOMAINJOINED
since the values are equal for a local user

Author: hurzelpurzel

pkg/crc/preflight/preflight_windows.go

@@ -155,7 +155,7 @@ var userPartOfCrcUsersAndHypervAdminsGroupCheck = Check{
 var errReboot = errors.New("Please reboot your system and run 'crc setup' to complete the setup process")
 
 func username() string {
-	if ok, _ := win32.DomainJoined(); ok {
+	if ok := win32.DomainJoined(); ok {
 		return fmt.Sprintf(`%s\%s`, os.Getenv("USERDOMAIN"), os.Getenv("USERNAME"))
 	}
 	return os.Getenv("USERNAME")

pkg/os/windows/win32/domains_windows.go

@@ -18,17 +18,28 @@ package win32
 
 import (
 	"errors"
+	"os"
 
 	"github.com/yusufpapurcu/wmi"
 )
 
-//nolint
+// nolint
 type Win32_ComputerSystem struct {
 	Partofdomain bool
 }
 
 // DomainJoined attempts to determine whether the machine is actively domain joined.
-func DomainJoined() (bool, error) {
+
+func DomainJoined() bool {
+	domainJoined, err := domainJoinedWmi()
+	if err != nil {
+		// simple additional domain check: a local User got the computername = domain
+		return os.Getenv("USERDOMAIN") != os.Getenv("COMPUTERNAME")
+	}
+	return domainJoined
+}
+
+func domainJoinedWmi() (bool, error) {
 	var c []Win32_ComputerSystem
 	q := wmi.CreateQuery(&c, "")