Skip to content

Commit 1e8617d

Browse files
committed
split installation of tray into separate selectable feature
1 parent 836238b commit 1e8617d

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

packaging/windows/WixUI_HK.wxs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<Property Id="WixUI_Mode" Value="InstallDir" />
1212
<Property Id="ARPNOMODIFY" Value="1" />
1313
<Property Id="ARPNOREPAIR" Value="1" />
14-
14+
1515
<DialogRef Id="BrowseDlg" />
1616
<DialogRef Id="DiskCostDlg" />
1717
<DialogRef Id="ErrorDlg" />
@@ -22,6 +22,7 @@
2222
<DialogRef Id="ProgressDlg" />
2323
<DialogRef Id="ResumeDlg" />
2424
<DialogRef Id="UserExit" />
25+
<DialogRef Id="FeaturesDlg" />
2526

2627
<!-- Make sure to include custom dialogs in the installer database via a DialogRef command,
2728
especially if they are not included explicitly in the publish chain below -->
@@ -57,11 +58,14 @@
5758
<Publish Dialog="InstallDirDlg" Control="Next" Event="SetTargetPath" Value="[WIXUI_INSTALLDIR]" Order="1">1</Publish>
5859
<Publish Dialog="InstallDirDlg" Control="Next" Event="DoAction" Value="WixUIValidatePath" Order="2">NOT WIXUI_DONTVALIDATEPATH</Publish>
5960
<Publish Dialog="InstallDirDlg" Control="Next" Event="SpawnDialog" Value="InvalidDirDlg" Order="3"><![CDATA[NOT WIXUI_DONTVALIDATEPATH AND WIXUI_INSTALLDIR_VALID<>"1"]]></Publish>
60-
<Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" Order="4">WIXUI_DONTVALIDATEPATH OR WIXUI_INSTALLDIR_VALID="1"</Publish>
61+
<Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Value="FeaturesDlg" Order="4">WIXUI_DONTVALIDATEPATH OR WIXUI_INSTALLDIR_VALID="1"</Publish>
6162

6263
<Publish Dialog="InstallDirDlg" Control="ChangeFolder" Property="_BrowseProperty" Value="[WIXUI_INSTALLDIR]" Order="1">1</Publish>
6364
<Publish Dialog="InstallDirDlg" Control="ChangeFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2">1</Publish>
6465

66+
<Publish Dialog="FeaturesDlg" Control="Back" Event="NewDialog" Value="WelcomeDlg">Installed</Publish>
67+
<Publish Dialog="FeaturesDlg" Control="Back" Event="NewDialog" Value="InstallDirDlg">NOT Installed</Publish>
68+
6569
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="InstallDirDlg">NOT Installed</Publish>
6670
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg">Installed</Publish>
6771

@@ -75,7 +79,7 @@
7579
<UIRef Id="WixUI_Common" />
7680

7781
<CustomAction Id="CA_Set_WIXUI_EXITDIALOGOPTIONALTEXT" Property="WIXUI_EXITDIALOGOPTIONALTEXT" Value="To finish installation of [ProductName] please restart your computer."/>
78-
<CustomAction Id="CA_Set_WIXUI_EXITDIALOGOPTIONALTEXT_NOREBOOT" Property="WIXUI_EXITDIALOGOPTIONALTEXT" Value="Suceesfully installed [ProductName]. You can now start [ProductName] from the Start menu."/>
82+
<CustomAction Id="CA_Set_WIXUI_EXITDIALOGOPTIONALTEXT_NOREBOOT" Property="WIXUI_EXITDIALOGOPTIONALTEXT" Value="Suceesfully installed [ProductName]."/>
7983
<InstallUISequence>
8084
<Custom Action="CA_Set_WIXUI_EXITDIALOGOPTIONALTEXT" After="FindRelatedProducts"><![CDATA[NOT WIX_UPGRADE_DETECTED]]></Custom>
8185
<Custom Action="CA_Set_WIXUI_EXITDIALOGOPTIONALTEXT_NOREBOOT" After="FindRelatedProducts"><![CDATA[WIX_UPGRADE_DETECTED]]></Custom>

packaging/windows/product.wxs.template

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,14 +140,16 @@
140140
<Custom Action="RemoveSMBShare" After='RemoveCrcDaemonTask'>Installed AND NOT UPGRADINGPRODUCTCODE</Custom>
141141
<ScheduleReboot After="InstallFinalize"> NOT Installed AND NOT REMOVE~="ALL" AND NOT WIX_UPGRADE_DETECTED</ScheduleReboot>
142142
</InstallExecuteSequence>
143-
<Feature Id="DefaultFeature" Level="1">
143+
<Feature Id="DefaultFeature" Title="Install core features" Absent="disallow" Level="1">
144144
<ComponentRef Id="CrcExe" />
145145
<ComponentRef Id="AdminHelper" />
146146
<ComponentRef Id="AddToPath"/>
147-
<ComponentRef Id="StartMenuEntry" />
148147
<ComponentRef Id="AddUserToCrcUsers" />
149148
<ComponentRef Id="VsockRegistryEntry" />
149+
</Feature>
150+
<Feature Id="TrayFeature" Title="Install system tray" Absent="allow" Level="2">
150151
<ComponentGroupRef Id="CrcTrayFiles" />
152+
<ComponentRef Id="StartMenuEntry" />
151153
</Feature>
152154
<UI>
153155
<UIRef Id="WixUI_ErrorProgressText"/>

0 commit comments

Comments
 (0)