Update Acra tools with kms cli #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Acra tools with KMS cli flags to support MasterKey loading
Collaborator
|
can we check the operational status of AT somehow? verify that it can start and respond to any request? because AT and AS are the most essential binaries. |
Add AcraTranslator tests
Lagovas
approved these changes
Jul 20, 2022
Collaborator
Lagovas
left a comment
Lagovas
left a comment
There was a problem hiding this comment.
lgtm but add comment please to last test why it is empty
|
|
||
|
|
||
| class TestTranslatorDisableCachedOnStartupWithAWSKMS(AWSKMSMasterKeyLoaderMixin, TestTranslatorDisableCachedOnStartup): | ||
| pass |
Collaborator
There was a problem hiding this comment.
add here a comment about the internal logic of master key loading too, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Acra tools with latest KMS CLI flags to support MasterKey loading.
Checklist
with new changes