Deserialization old containers on decryption fail #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added deserialization of old container on decryption fail
fixed after review
redo redundant changes
redo redundant changes
fixed unit tests
Lagovas
approved these changes
Apr 18, 2022
Lagovas
pushed a commit
that referenced
this pull request
Apr 28, 2022
* zhars/fix_deserializon_old_container_on_fail Added deserialization of old container on decryption fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acra should return pure old container as is in case of decryption failure. Currently, on newly found old container(AcraStruct/AcraBlock) Acra serialize it to general container to get corresponded handler during decryption, but in case of failure return general container which is not correct.
Note:Acra should return deserialized container only in case of pure AcraStruct/AcraBlock, in all other scenarios general container should be returned.Checklist
with new changes