Remove acra-connector from acra-server/acra-translator #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial removing connector from acra-server and acra-translator
Lagovas
reviewed
Jan 12, 2022
delete connector and all related files
fixed integration tests
fixed mysql integration tests
Lagovas
reviewed
Jan 25, 2022
fixed aftre review
fixing integration tests next iteration
fixed SSLMySQLMixin
added checkSkip for non-tls tests
fixed typo in tests
fixed path typo
Lagovas
reviewed
Jan 31, 2022
Collaborator
Lagovas
left a comment
Lagovas
left a comment
There was a problem hiding this comment.
and general petition - make ctrl+f "connector" and remove it where it possible if it doesn't take a lot of time, please
tests/test.py
Outdated
| @@ -654,6 +600,7 @@ def drop_tables(): | |||
| engine_raw = sa.create_engine( | |||
| '{}://{}:{}/{}'.format(DB_DRIVER, DB_HOST, DB_PORT, DB_NAME), | |||
| connect_args=connect_args) | |||
| print(connect_args) | |||
Collaborator
There was a problem hiding this comment.
remove debug output, please
fixed after review
fixed after review
updated CHANGELOG_DEV.md file with info about connector removing
…nd_translator # Conflicts: # CHANGELOG_DEV.md
Lagovas
deleted the
zhars/T2421/remove_connector_from_server_and_translator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial removing acra-connector from acra-server and acra-translator cmds.
Checklist
with new changes