-
Notifications
You must be signed in to change notification settings - Fork 133
Updated keymaker behaviour #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added ability to keymaker to generate keys with empty client_id
tests/test.py
Outdated
| subprocess.check_output( | ||
| ['./acra-keymaker', '--keystore={}'.format(KEYSTORE_VERSION), | ||
| '--keys_output_dir={}'.format(folder), | ||
| '--client_id=''', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will print next code:
a = '--client_id='''
print(a)
?
I suggest to rewrite this literal to '--client_id' or "--client_id=''" to be more readable what the actual value will be used. Because now we check client_id validation, not empty value)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this code will produce just -client_id= which is totally fine for our scenario, but in case of simply passing --client_id it wont start because you are passing param but not specified its value:)
a = '--client_id='''
print(a)
fixed integration tests
fixed after review
Lagovas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if CI tests pass
split vault unit tests by versions
Updated
keymakertool to be able to generate keys that are not usingclient_idwith its empty definition.client_idwill be validated only for generation of keys with requiredclient_idChecklist
with new changes