Skip to content

fix(goreleaser): invalid Slack blocks configuration #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix(goreleaser): invalid Slack blocks configuration #126

merged 1 commit into from
Dec 20, 2022

Conversation

theseion
Copy link
Collaborator

No description provided.

@theseion theseion requested a review from fzipi December 20, 2022 15:59
@fzipi
Copy link
Member

fzipi commented Dec 20, 2022

Did we tested this? Maybe the release notes need the same > syntax?

@theseion
Copy link
Collaborator Author

I couldn't test it because I don't have a token. But goreleaser check said the config was valid.
> is for multiline strings, where single newlines are replaced withs spaces and double newlines with a single newline. What do you mean by "Maybe the release notes need the same > syntax?".

fzipi
fzipi approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fzipi fzipi merged commit 16cfbca into coreruleset:main Dec 20, 2022
@theseion theseion deleted the fix-goreleaser-slack-announcement branch December 20, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @fzipi