-
-
Notifications
You must be signed in to change notification settings - Fork 235
feat: Add support for custom icons in Question #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
+ Coverage 97.24% 97.25% +0.01%
==========================================
Files 55 55
Lines 6247 6276 +29
==========================================
+ Hits 6075 6104 +29
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sisp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this feature, @Flexonze! 🙇
It seems that some TUI assertions aren't accurate. Let me know if you need some help with debugging this. Other than that, everything looks great! 🥇
…er into feat-custom-question-icons
|
c32765e should fix the assertion issue. Hopefully it fixes the encoding problem too. |
sisp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question – see inline comment.
sisp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @Flexonze! 🥇 Thanks for your contribution! 🙇
Closes #1102
This is my first contribution to Copier. I appreciate the project and would welcome any feedback on the implementation :)