Skip to content

Conversation

@Flexonze
Copy link
Contributor

@Flexonze Flexonze commented Nov 2, 2025

Closes #1102

This is my first contribution to Copier. I appreciate the project and would welcome any feedback on the implementation :)

@Flexonze Flexonze changed the title feat: add custom qmark parameter for question prompts feat: Add support for custom icons in Question Nov 2, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (de88305) to head (bec18fb).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
+ Coverage   97.24%   97.25%   +0.01%     
==========================================
  Files          55       55              
  Lines        6247     6276      +29     
==========================================
+ Hits         6075     6104      +29     
  Misses        172      172              
Flag Coverage Δ
unittests 97.25% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this feature, @Flexonze! 🙇

It seems that some TUI assertions aren't accurate. Let me know if you need some help with debugging this. Other than that, everything looks great! 🥇

@Flexonze Flexonze requested a review from sisp November 9, 2025 23:22
@Flexonze
Copy link
Contributor Author

Flexonze commented Nov 9, 2025

c32765e should fix the assertion issue. Hopefully it fixes the encoding problem too.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question – see inline comment.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @Flexonze! 🥇 Thanks for your contribution! 🙇

@sisp sisp merged commit d281fb2 into copier-org:master Nov 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for custom icons in Questions

2 participants