Skip to content

Conversation

@34j
Copy link
Contributor

@34j 34j commented Oct 25, 2025

Closes #2373
Related: #1940

@34j 34j changed the title fix: fix user defaults not reflected if default is not set in copier.yml fix: fix user defaults not reflected if default is MISSING in copier.yml Oct 25, 2025
@34j 34j force-pushed the fix/fix-settings-not-reflected-if-default-missing branch from 5c2d64b to 69c798a Compare October 25, 2025 15:27
@34j 34j force-pushed the fix/fix-settings-not-reflected-if-default-missing branch from 470cfce to 6195c07 Compare October 26, 2025 01:53
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (b9f2d11) to head (6195c07).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2374   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files          55       55           
  Lines        6225     6225           
=======================================
  Hits         6045     6045           
  Misses        180      180           
Flag Coverage Δ
unittests 97.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing a fix for this bug, @34j! 🙇

LGTM! 🎉

@sisp sisp enabled auto-merge (squash) October 26, 2025 10:31
@sisp sisp merged commit e82ac24 into copier-org:master Oct 26, 2025
24 checks passed
@34j 34j deleted the fix/fix-settings-not-reflected-if-default-missing branch October 26, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User defaults in Copier settings (<CONFIG_ROOT>/settings.yml) will not be reflected unless default: ... is explicitly set in copier.yml

2 participants