feat(toolbar): Insert Current Location button (addresses #1559) #3893
+98
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 22, 2025 13:08
… and new setting \n\n- Replace plain domain input with autocomplete component (prefix filter)\n- Expose setting (array of provider domains)\n- Import autocomplete component in register plugin\n- Docs: add configuration section for (with example)\n\nAddresses conversejs#2740 (bounty/good-first-issue).
…e \n\n- Use property bindings for .list and .data (remove quoted strings)\n- Trigger suggestions on '@' with min_chars=1\n- Merge configured into domain list\n\nAddresses conversejs#2929 (bounty).
…player - <figure role=group aria-label> and <audio aria-label tabindex=0 preload=metadata> - Caption/hostname continues to render when not hidden Addresses conversejs#3382 (bounty): improve screen reader access to play controls.
…ddresses conversejs#1559)\n\n- New visible_toolbar_buttons.location (default true)\n- Adds location button to chat and MUC toolbars\n- Uses Geolocation API to insert geo:lat,lon into the draft\n- Leverages existing geo: rendering support (Texture addMapURLs)
jcbrand
requested changes
Dec 14, 2025
| ] | ||
| }); | ||
| Suggestions are shown via the ``<converse-autocomplete>`` component and filtered by prefix. |
| registration_domain: '', | ||
| // Optional list of known public XMPP providers to suggest during registration | ||
| // e.g.: ['conversejs.org', 'jabber.org', 'xmpp.jp'] | ||
| registration_providers: [] |
Member
There was a problem hiding this comment.
This also looks unrelated to this PR.
| /> | ||
| ?required=${true} | ||
| .value=${el.domain || ''} | ||
| ></converse-autocomplete> |
Member
There was a problem hiding this comment.
Same here. @Bennethxyz Please remove any commits and changes unrelated to this PR which is about sending your location. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toolbar button to insert your current location into the compose box.\n\nWhat\n- New visible_toolbar_buttons.location (default true)\n- Button uses the Geolocation API and inserts a geo:lat,lon URI (six decimals)\n- Works in 1:1 and MUC; text already renders via existing geo: support\n\nWhy\n- Addresses #1559 (bounty): make it easy to send current location.\n\nNotes\n- Gracefully handles browsers without geolocation (toast warning)\n- No auto-send; it inserts into draft so users can edit before sending.