feat(rsip): populate slugs for GitLab-provided inputs #513
+69
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-roesch
force-pushed
the
feat/rsip-slugs
branch
from
4605e2e to
3890a68
Compare
Signed-off-by: Marvin Rösch <[email protected]>
marvin-roesch
force-pushed
the
feat/rsip-slugs
branch
from
3890a68 to
8211700
Compare
Contributor
Author
|
Having trouble with KinD on my local machine right now, so sorry for playing whack-a-mole with the tests 😅 |
stefanprodan
approved these changes
Dec 10, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @marvin-roesch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #501 as requested by @stefanprodan. I have so far only added slugs for GitLab branches, tags, and merge requests since I've realized that none of the providers actually expose a "slug" for these particular types in their APIs.
GitLab at least has CI/CD variables like
CI_COMMIT_REF_SLUGwhere they provide these to users. AFAICT, neither Azure DevOps nor GitHub have a "standard" definition of how to slugify their data.I have introduced a dedicated slugification function that matches GitLab's behavior, as
slug.Makeis configured globally and changing the defaults would mean a breaking change.Let me know if you'd rather use a different approach or if this should also be expanded to GitHub and Azure DevOps (maybe with
slug.Makethere).