Skip to content

Pay22 2060 modificar sdk php para soportar fiscal entity #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 13, 2023
Merged

Pay22 2060 modificar sdk php para soportar fiscal entity #55

merged 8 commits into from
Oct 13, 2023

Conversation

fcarrero
Copy link
Collaborator

  • fiscal entity new params
  • update charge
  • shipping contact new params
  • php new version
  • move monthly_installments inside payment method

jalonsoDevConekta
jalonsoDevConekta reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@jalonsoDevConekta jalonsoDevConekta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No encuentro la actualización para enviar fiscal_entity al crear la orden.

image

leofischer
leofischer reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@leofischer leofischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve bien, te deje unas sugerencias menor y una duda

fcarrero
fcarrero commented Oct 13, 2023
View reviewed changes
@fcarrero
Copy link
Collaborator Author

No encuentro la actualización para enviar fiscal_entity al crear la orden.

image

https://github.com/conekta/openapi/pull/55/files#r1358721581

@jalonsoDevConekta
Copy link
Contributor

Nos ayudas a colocarlo en los examples por favor
image

jalonsoDevConekta
jalonsoDevConekta approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@jalonsoDevConekta jalonsoDevConekta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fcarrero fcarrero requested a review from leofischer October 13, 2023 19:49
@fcarrero fcarrero merged commit d86550f into main Oct 13, 2023
@fcarrero fcarrero deleted the PAY22-2060-modificar-sdk-php-para-soportar-fiscal-entity branch October 13, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofischer leofischer leofischer approved these changes

@nicocedron nicocedron Awaiting requested review from nicocedron

+1 more reviewer

@jalonsoDevConekta jalonsoDevConekta jalonsoDevConekta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fcarrero @jalonsoDevConekta @leofischer