Skip to content

Conversation

@scott-routledge2
Copy link
Contributor

@scott-routledge2 scott-routledge2 commented Jun 2, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Supersedes: #28648

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/bodo/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: knassre-bodo. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bodo/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/bodo/meta.yaml:

  • ℹ️ top-level output has some malformed specs:
  • In section host: libcurl ~= 8.0, hdf5 >=1.14.3,<1.14.4.0a0=mpi_mpich_*, mpich 4.1.*=h*
  • In section run: mpich *=h*
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15401026967. Examine the logs at this URL for more detail.

@IsaacWarren
Copy link

I confirm that I am willing to be listed as a maintainer for this recipe.

2 similar comments
@scott-routledge2
Copy link
Contributor Author

I confirm that I am willing to be listed as a maintainer for this recipe.

@ehsantn
Copy link

ehsantn commented Jun 2, 2025

I confirm that I am willing to be listed as a maintainer for this recipe.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jun 2, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bodo/meta.yaml) and found some lint.

Here's what I've got...

For recipes/bodo/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [53, 54, 76]

For recipes/bodo/meta.yaml:

  • ℹ️ top-level output has some malformed specs:
  • In section host: hdf5 >=1.14.3,<1.14.4.0a0=mpi_mpich_*, hdf5 >=1.14.3,<1.14.4.0a0=*mpi_impi_*, mpich 4.1.*=h*
  • In section run: mpich *=h*
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15404418554. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jun 2, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bodo/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/bodo/meta.yaml:

  • ℹ️ top-level output has some malformed specs:
  • In section host: hdf5 >=1.14.3,<1.14.4.0a0=mpi_mpich_*, hdf5 >=1.14.3,<1.14.4.0a0=*mpi_impi_*, mpich 4.1.*=h*
  • In section run: mpich *=h*
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15779606486. Examine the logs at this URL for more detail.

@hadia206
Copy link

hadia206 commented Jun 3, 2025

I confirm that I am willing to be listed as a maintainer for this recipe.

@DrTodd13
Copy link

DrTodd13 commented Jun 4, 2025

I confirm that I am willing to be listed as a maintainer for this recipe.

@scott-routledge2 scott-routledge2 marked this pull request as ready for review June 5, 2025 13:58
@scott-routledge2
Copy link
Contributor Author

@conda-forge/help-python-c, ready for review!

@knassre-bodo
Copy link

I confirm that I am willing to be listed as a maintainer for this recipe.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@scott-routledge2
Copy link
Contributor Author

@conda-forge/help-python-c, bump

@scott-routledge2 scott-routledge2 mentioned this pull request Jun 20, 2025
10 tasks
@scott-routledge2
Copy link
Contributor Author

@carterbox, this is the new PR for adding bodo recipe to conda-forge that has applied feedback from the old PR (which can be closed, I don't have permission to do so). I was wondering if it would be possible to re-review this, since Bodo is going to be an optional dependency for accelerating user defined functions in Pandas 3.0, which will be released soon. Thanks!

Links:
pandas-dev/pandas#61467
pandas-dev/pandas#61032

cc @datapythonista

- pandas >=2.2,<2.3
- fsspec >=2021.09
- h5py
- mpich 4.1.*=h* # [not win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mpich is not a python package

Comment on lines +13 to +14
--config-settings=cmake.args="-DCMAKE_INSTALL_PREFIX=$PREFIX;-DCMAKE_INSTALL_LIBDIR=lib;-DCMAKE_FIND_ROOT_PATH='$PREFIX;$CONDA_PREFIX_OLD/x86_64-conda-linux-gnu/sysroot';-DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY" \
.
Copy link
Member

@carterbox carterbox Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We define $CMAKE_ARGS for the compilers in our channel. If you have issues cross-compiling, look at this variable.

@carterbox carterbox merged commit 12b7f8d into conda-forge:main Jun 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants