-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add alma10 sysroot #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…5.09.17.06.41.22 Other tools: - conda-build 25.7.0 - rattler-build 0.47.0 - rattler-build-conda-compat 1.4.6
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19406394618. Examine the logs at this URL for more detail. |
…5.11.09.23.10.12 Other tools: - conda-build 25.9.0 - rattler-build 0.49.0 - rattler-build-conda-compat 1.4.9
|
Ah right we need the images first |
|
OK, the reason for the failures here is that the packaging in alma10 changed; the long story short (AFAICT) is that RHEL 10 seems to have cleaned up some leftovers of the In alma9, the glibc bits were still packaged in whereas in RHEL 10 everything gets delivered in |
9ebca9b to
75f30eb
Compare
|
Good that I added some extra tests; one of them caught (or would have caught it, had the test not failed otherwise 😅) |
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have at least historrically kept branches on the upstream feedstock for each sysroot version. We should do that here and so the PR needs to be redirect to a branch. Feel free to make one.
…5.11.15.23.15.53 Other tools: - conda-build 25.9.0 - rattler-build 0.49.0 - rattler-build-conda-compat 1.4.9
|
Ack yes you are right @h-vetinari. We should make a branch for alma9 from the current main! Thank you! |
|
OK, this should be ready now! PTAL :) |
|
Branch |
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
| sha256: 50808a6a71fd9a3d5b3db2604f825af8aa6cf0020dd8f1d0edca1b0bc77729f9 # [cross_target_platform == "linux-ppc64le"] | ||
| sha256: e7a9df0d9eb747b1dacf13636a4defb42123a0aa3d166adff9970736d1be073c # [cross_target_platform == "linux-s390x"] | ||
|
|
||
| - folder: binary-glibc-headers # [cross_target_platform in ("linux-64", "linux-s390x")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be nice if they stopped moving stuff around.
| - test -f $PREFIX/{{ target_machine }}-conda-linux-gnu/sysroot/lib/libc.so.6 | ||
| - test -f $PREFIX/{{ target_machine }}-conda-linux-gnu/sysroot/sbin/ldconfig | ||
| - test -f $PREFIX/{{ target_machine }}-conda-linux-gnu/sysroot/usr/lib/crt1.o | ||
| # the files below are just a sample of the full content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for expanding the tests!
|
Thanks for the review! |

https://repo.almalinux.org/vault/10.0/BaseOS/ exists but is still empty. It should be filled once alma 10.1 is out, which might happen in November. In the meantime, use packages from https://repo.almalinux.org/almalinux. Later, we should simply be able to revert 0de3517.
Fixes #91