-
-
Notifications
You must be signed in to change notification settings - Fork 6
BUG: Fix Windows install paths #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12303936871. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| files: | ||
| - lib/libcudss.so.* # [linux] | ||
| - bin/cudss64_0.dll # [win64] | ||
| - Library/bin/cudss64_0.dll # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work on Windows ARM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference between win and win64 selectors is "any windows" vs "64-bit windows", so the real question is "Does this work on 32-bit Windows?" The answer is "No", but that's moot because conda-forge doesn't have separate 32-bit/64-bit Windows build variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also no builds for cudss on Windows ARM, so we don't know what the filename would be for those builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically that would have been true
In the near future win64 will be used to distinguish Windows x86_64 from Windows arm64: conda-forge/conda-forge-pinning-feedstock#5440
Hence the question about Windows ARM
It is ok that it is unsupported atm. Just thought we were trying to clarify between these newer Windows architectures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they patching conda-build too? Because according to the docs, win64 doesn't know about x86 vs arm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conda already knows about it: conda/conda#11778
Most likely we will need to compose OS & arch selectors using this sort of approach
For now win64 has been used as shorthand for win and x86_64. Similar to how linux64 is already used
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes #1
The build number is not bumped because the linux builds are unchanged.