Skip to content

Conversation

@isuruf
Copy link
Member

@isuruf isuruf commented Nov 8, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner November 8, 2024 21:07
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@isuruf isuruf requested review from beckermr and h-vetinari November 8, 2024 21:24
@beckermr
Copy link
Member

beckermr commented Nov 8, 2024

I don't know enough about the CUDA requirements to properly review this PR. Hopefully someone else can double check.

@isuruf isuruf requested a review from jakirkham November 8, 2024 22:11
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine, but we need a patch version bump

@h-vetinari
Copy link
Member

(came looking for this because things broke in conda-forge/libhwloc-feedstock#83)

There's way more clean-ups possible (some discussion on this in #363), but for now we should quickly merge this to unblock recipes that cross-compile cuda.

@h-vetinari
Copy link
Member

This broke a couple other feedstocks too (e.g. arrow), so let's merge this and do any other relevant clean-ups in #363 (or another PR)

@h-vetinari h-vetinari merged commit d30ebf1 into conda-forge:main Nov 9, 2024
0 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants