Skip to content

Conversation

@isuruf
Copy link
Member

@isuruf isuruf commented Nov 26, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner November 26, 2023 20:36
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

Do you really want to support a variable that is sometimes a string, sometimes a boolean?

On the linux code path we have:

 33         if [ -f ${CI_SUPPORT}/${CONFIG}.yaml ]; then                                                                                                                                                       
 34             echo "CMAKE_CROSSCOMPILING_EMULATOR: " >> ${CI_SUPPORT}/${CONFIG}.yaml
 35             echo "- /usr/bin/qemu-${HOST_PLATFORM_ARCH}-static"  >> ${CI_SUPPORT}/${CONFIG}.yaml
 36             echo "CROSSCOMPILING_EMULATOR: " >> ${CI_SUPPORT}/${CONFIG}.yaml    
 37             echo "- /usr/bin/qemu-${HOST_PLATFORM_ARCH}-static"  >> ${CI_SUPPORT}/${CONFIG}.yaml
 38         fi 

@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2023

I agree that it's confusing. However, we usually test that it is non-empty on Linux too. CMake use CMAKE_CROSSCOMPILING_EMULATOR to launch binaries, but I'm not setting it here because I couldn't think of what to set here. The emulator is called by the OS itself so there's no path for it.

@hmaarrfk
Copy link
Contributor

Understood on the non-emptiness front. Is the following suggestion possible:
conda-forge/conda-smithy#1808 (comment)

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me, but I haven't tested on windows. merge if you have

@isuruf
Copy link
Member Author

isuruf commented Nov 27, 2023

This is tested on CI here.

@isuruf isuruf merged commit 56a6eb6 into conda-forge:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants