set BUILD_PLATFORM and TARGET_PLATFORM on windows #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Member
Author
|
@conda-forge-admin, rerender |
Member
Author
|
@conda-forge/core, this is ready for a review. |
…nda-forge-pinning 2023.07.03.16.57.58
hmaarrfk
reviewed
Jul 4, 2023
Comment on lines
+110
to
+112
| cat .ci_support\%CONFIG%.yaml | shyaml get-value target_platform.0 %BUILD_PLATFORM% > target_platform.txt | ||
| set /p TARGET_PLATFORM=<target_platform.txt | ||
| del target_platform.txt |
Contributor
There was a problem hiding this comment.
I don't know batch scripting too well, but I couldn't find a better way to "store things in a batch variable".
Is it true that here you are this difficulty in storing things in a file, before reading in the file?
Member
Author
There was a problem hiding this comment.
Yes, there's another syntax to do this, but it's really unreadable. This technique is used in the same file just few lines above.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)