Delete openmp c++17 kernel folder and contents #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
|
@SylvainCorlay @vgvassilev @anutosh491 pinging for review |
|
Can we still run openmp after this PR? |
OpenMP has not currently been implemented into the xeus-cpp kernel. I tried a long time ago to add support here #100 . I plan to have another go again soon, but currently everything in this folder is unused. |
|
I’d prefer to fix it instead of removing and re-adding it again. |
I'll change this PR to my second attempt at adding openmp support then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Until we actually have an openmp kernel this folder is just in the repo doing nothing, so this PR removes it until work is done to finish adding openmp support.
Fixes # (issue)
Type of change
Please tick all options which are relevant.