transformations: move Cython to pure Python #36830
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpurnell1
changed the title
Contributor
|
For this, I think we want to explore just using pure Python + numpy instead. |
Contributor
Author
This has been implemented! I also added a few more tests, just to verify everything is working as expected. Let me know what you think |
Contributor
|
trigger-jenkins |
adeebshihadeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cython code for transformations is removed and reimplemented solely in Python and NumPy. Additional tests are also added to test expected errors/failures. This is part 2 of 10 of the larger PR to fully remove cython from openpilot.
Verification
op test common/transformationsbefore these changes:op test common/transformationsafter these changes: