params: Move all Cython to Python and C++ #36829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mici raylib UI Preview✅ Videos are identical! View Diff Report |
Contributor
raylib UI PreviewAll Screenshots
|
mpurnell1
changed the title
Contributor
Author
|
Not sure if it's preferred for me to add lint supression in all 4 files that it complained about or to leave them alone and have the CI be failing. Let me know and I can remove the comments if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using #35854 as a reference, the Cython code for params is removed and reimplemented in Python and C++. Additional tests are also added to test expected errors/failures. This is part 1 of 10 of the larger PR to fully remove cython from openpilot.
Verification
op test common/tests/test_params.pybefore these changes:op test common/tests/test_params.pyafter these changes: