[OPIK-937] [P SDK] Opik Evaluate crash when task is wrapped in functools.partial #3155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Problem: The error handling code in the decorator was trying to access
func.__name__
directly, butfunctools.partial
objects don't have this attribute, causingAttributeError
:functools.partial
object has no attribute__name__
.Solution:
get_function_name()
insrc/opik/decorator/inspect_helpers.py:50-57
that safely handlesfunctools.partial
objects byaccessing the underlying function's
__name__
attribute.src/opik/decorator/base_track_decorator.py
and 1 instance insrc/opik/decorator/tracker.py
to use the safe helper insteadof direct
func.__name__
access.Key improvements:
__name__
attribute<unknown>
for objects without namesThe user's
opik.evaluate()
calls withfunctools.partial
functions will now work correctly without crashing.Change checklist
Issues
Testing
Added comprehensive tests.
Documentation
Added doctoring where required.