backend (auth): Remove Session usage, add JWT bearer auth logic, dynamically set router dependencies #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianjing-li
requested review from
a team,
EugeneLightsOn,
malexw and
scottmx81
as code owners
lusmoura
approved these changes
Jun 3, 2024
Collaborator
lusmoura
left a comment
lusmoura
left a comment
There was a problem hiding this comment.
LGTM! What should we do about the tests that are failing? Should we add JWT_SECRET_KEY to the repo?
EugeneLightsOn
approved these changes
Jun 3, 2024
Collaborator
EugeneLightsOn
left a comment
EugeneLightsOn
left a comment
There was a problem hiding this comment.
Looks good to me, thanks. Only take a look at Luisa's comments.
lusmoura
reviewed
Jun 5, 2024
EugeneLightsOn
requested changes
Jun 6, 2024
Collaborator
EugeneLightsOn
left a comment
EugeneLightsOn
left a comment
There was a problem hiding this comment.
Great PR, thank you
Please restore Make win-setup and win-first-run commands and good to go.
malexw
approved these changes
Jun 6, 2024
Collaborator
malexw
left a comment
malexw
left a comment
There was a problem hiding this comment.
I didn't take a close look at the tests, but this looks pretty good to me
…into add-jwt Please enter a commit message to explain why this merge is necessary,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionMiddlewareusage, andget_sessionendpointGET /auth_strategiesendpoint/loginand/authto return a JWT token on successful authenticationconfig/routers.pyfile to define default or auth dependencies. These dependencies are set during app creation time