Skip to content

Conversation

@malexw
Copy link
Collaborator

@malexw malexw commented May 24, 2024

When we removed the proxy from the frontend, we didn't update the CLI setup script to use localhost:8000 as the default backend instead of backend:8000.

This pull request updates the NEXT_PUBLIC_API_HOSTNAME_DEFAULT in the main.py file.

Summary

The pull request updates the NEXT_PUBLIC_API_HOSTNAME_DEFAULT variable in the main.py file to use "http://localhost:8000" as the default API hostname instead of "http://backend:8000".

Changes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@27667d6). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage        ?   88.57%           
=======================================
  Files           ?      115           
  Lines           ?     3633           
  Branches        ?        0           
=======================================
  Hits            ?     3218           
  Misses          ?      415           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ty!

@malexw malexw force-pushed the alexw/update-default-api-host branch from 222f54c to 25a45de Compare May 25, 2024 02:30
@malexw malexw merged commit 5b68bac into main May 25, 2024
@malexw malexw deleted the alexw/update-default-api-host branch May 25, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants