Skip to content

added unsigned char casting for errors in esp-idf building system #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FBEZ
Copy link

@FBEZ FBEZ commented Jun 20, 2025

While porting tinyexpr to [Espressif's ESP-IDF](https://github.com/espressif/esp-idf), I encountered a compiler warning related to the use of signed char types in the isalpha and isdigit macros:

array subscript has type 'char' [-Werror=char-subscripts]

This appears to be a platform-specific issue. I wasn’t able to reproduce the same warning on macOS, even when explicitly setting the compiler flags:

-fsigned-char -Wchar-subscripts -Werror=char-subscripts

Since I’m considering using your nice project as an example of how to port a C library as an ESP-IDF component, I wanted to contribute this small fix and share it back with you—this way, I can reference your repo directly in my write-up.

Thanks for maintaining such a clean and minimal implementation! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant