Skip to content

change package to org.codehaus.plexus.build #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

change package to org.codehaus.plexus.build #43

merged 2 commits into from
Oct 24, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Oct 5, 2022 •
edited
Loading

  • change package name to org.codehaus.plexus.build.incremental

@olamy olamy added the enhancement New feature or request label Oct 5, 2022
@olamy olamy mentioned this pull request Oct 5, 2022
Closed
@laeubi
Copy link
Collaborator

laeubi commented Oct 5, 2022

Can we maybe change the package to org.codehaus.plexus.build.api instead? that would better match the name and incremental is only one aspect here and might confuse people with maven-incremental-builds ..

@olamy
Copy link
Member Author

olamy commented Oct 5, 2022

Can we maybe change the package to org.codehaus.plexus.build.api instead? that would better match the name and incremental is only one aspect here and might confuse people with maven-incremental-builds ..

good idea

@olamy olamy changed the title change package to org.codehaus.plexus.build.incremental change package to org.codehaus.plexus.build Oct 5, 2022
@olamy
Copy link
Member Author

olamy commented Oct 5, 2022

done

laeubi
laeubi approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olamy olamy requested a review from slachiewicz October 9, 2022 11:36
@olamy olamy added breaking and removed enhancement New feature or request labels Oct 24, 2022
@olamy olamy merged commit e55662a into master Oct 24, 2022
@olamy olamy deleted the package-change branch October 24, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olamy @laeubi @slachiewicz