fix: Fixes pluralization of "Callback URL" #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterkos
requested changes
Dec 9, 2020
cbaudouinjr
requested review from
peterkos
and removed request for
JeremyRudman
|
Called "URIs" somewhere and "URLs" elsewhere "because doorkeeper" - @cbaudouinjr 2k20 |
cbaudouinjr
added a commit
that referenced
this pull request
Dec 11, 2020
* Fixed issue on desktop * Map overflow scroll Signed-off-by: Peter Kos <[email protected]> * Fix scroll issue Signed-off-by: Peter Kos <[email protected]> * Fixed toggle button; fits screen, sidebar width Sidebar width is better Toggle button fills height of navbar Signed-off-by: Peter Kos <[email protected]> * fix: Allows optional assets to be unset * Fixes test * feat: Redesigns OAuth2 portal (#404) * feat: Redesigns OAuth2 portal * fix: Some Hound issues * Changes application verbiage * Fixes ID issue * Fixes table link and sign out button * Peter's wishes * fix: Fixes MyMLH branding in config (#412) * feat(settings): Simplifies Config (#409) * feat(settings): Simplifies Config * Resolves Hound issues * Update app/views/manage/configs/index.html.haml Co-authored-by: Peter Kos <[email protected]> * design: Increases the font-weight and reorganizes the page * fix: Hound issues Co-authored-by: Peter Kos <[email protected]> * feat: Adds support for digital-only hackathons (#395) * feat: Adds support for digital-only hackathons * fix: Provides clarity for what is removed from digital hackathons Co-authored-by: Peter Kos <[email protected]> * feat: Adds GitHub Action for releases (#426) * feat: Adds GitHub Action CI testing (#423) * feat: Adds GitHub Action CI testing * fix: Adds sudo * refactor: Changes naming * Removes travis.yml * docs: Adds ruby version comment * feat: Adds Legal Agreements object for dynamic agreements (#429) * feat: Adds Legal Agreements object for dynamic agreements * fix: Fixes several bugs with agreement error checking * fix: Fixes several Hound issues * fix: Fixes some more Hound issues * Update app/views/application/_unaccepted_agreements_notice.html.haml Co-authored-by: Peter Kos <[email protected]> * fix: Fixes Peter's requests * Fix agreement checkbox wrap with small names Signed-off-by: Peter Kos <[email protected]> * Fix straggling merge conflict error Signed-off-by: Peter Kos <[email protected]> * Removed agreements card Signed-off-by: Peter Kos <[email protected]> * Force validation for agreement on questionnaire pg FRONTEND Signed-off-by: Peter Kos <[email protected]> Co-authored-by: Peter Kos <[email protected]> * refactor: Changes hackathon_manager to HackathonManager (#417) Co-authored-by: Peter Kos <[email protected]> * feat: Adds GitLab VCS URL support (#415) * feat: Adds GitLab VCS URL support * fix: Corrects Bitbucket capitalization * Update schema.rb Removes events * Update test/models/questionnaire_test.rb Co-authored-by: Peter Kos <[email protected]> * Update test/models/questionnaire_test.rb Co-authored-by: Peter Kos <[email protected]> Co-authored-by: Peter Kos <[email protected]> * fix: Fixes pluralization of "Callback URL" (#421) * fix: Fixes pluralization of "Callback URL" * refactor: Adds "(s)" to Callback URLs Co-authored-by: Peter Kos <[email protected]> * refactor: Removes legal section from config (#440) * refactor: Removes legal section from config * refactor: Removes agreement asset from locals * Removes additional PDF asset messages Co-authored-by: Peter Kos <[email protected]> * fix(map): changed map overflow from scroll to auto (#428) changed the map div from overflow scroll to overflow auto so that the scroll bars do not show up when the map is large enough to not need them Co-authored-by: Peter Kos <[email protected]> * build(deps-dev): Bump semantic-release from 17.2.1 to 17.2.3 (#435) Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 17.2.1 to 17.2.3. - [Release notes](https://github.com/semantic-release/semantic-release/releases) - [Commits](semantic-release/semantic-release@v17.2.1...v17.2.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Kos <[email protected]> Co-authored-by: Peter Kos <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adds an "s" to the Callback URL table header.
fixes #420