feat: Adds event calendar support #259

JeremyRudman · 2020-06-13T17:51:11Z

screenshots as of 12/10/2020:

made a page to to view upcoming events in the management tools

calendar has all the features needed need to make it less janky and possible add/remove features based on feedback

created a page to view, make, and delete events. These events contain a title, description, location, owner(s), if it is a public and/or all day event and when it starts and stops.

app/views/manage/events/index.html.haml

app/models/event.rb

app/controllers/manage/messages_controller.rb

test/models/event_test.rb

app/controllers/manage/events_controller.rb

app/assets/javascripts/events.js

made the code comply with houndci-bot requests and removed the all day bool for a event

app/controllers/manage/events_controller.rb

implemented owners in a similar way to message recipients it will only allow for the selection of admin user as the owner(s) of a event. No owners it also allowed.

into issue-226

JeremyRudman · 2020-08-10T08:30:40Z

blocked by issue-222

# Conflicts: # Gemfile.lock

peterkos

Great work! Apologies for the infinite delay on my review.

I'll review the API tomorrow when I can check in with how we're implementing it on brickhack.io to get a real feel for it. Also make sure to backmerge from 2.2!

Notes:

What time zone is this intended for? Whatever the server runs on? Should we allow for hackathons to set that as a config option, or here in the schedule? (Prob as separate issue unless its ez to implement)
Not everyone might be comfortable working in 24hr time; how easy would it be to make this 12hr time with PM/AM?
A little more coverage on the render methods of events-controller.rb would be great if you could throw those in!

Suggestions:

Tests seem very access-oriented rather than behavior-oriented; a test for the below bug would be great to add in there!
Bug: can create events with earlier finish than start date (time or day)

Edit	Applied

Should have pointer: cursor; on event row hover
Remove extra ml-1 mr-1margin around form items, making them unaligned:
(Not sure how easy to fix, seems to be from simpleform's bootstrap styling)

"Update Event" text seems strange; can't find it in code? I'd suggest keeping either as "Save" or "Update Event" over all states of that button

app/views/manage/schools/_form.html.haml

app/views/manage/users/_form.html.haml

.github/workflows/release.yml

app/assets/javascripts/events.js

JeremyRudman · 2021-01-23T05:57:21Z

the time zone is utc-0 I am assuming we could add a timezone in the config but I don't think that would be necessary since that would not change anything with how the information is displayed

changing time to a am/pm is not supported by simpleform so this should be held off for a simple form refactor

I fixed the save button bug by manually setting the submit button text. I have no idea why this bug exists though since that was not required in other forms
= f.button :submit, 'Save'

into issue-226

app/assets/javascripts/events.js

app/models/event.rb

* build: Reduces CHECKS attempts to 100 from 300 (#495) * build: Updates GitHub Actions to work on all version branches (#509) * feature: Adds Users & Staff docs (#497) * fix: Resolves job execution failure on nil questionnaires (#529) * feat: Adds event calendar support (#259) * build(deps): Upgrade yarn * build(deps): Upgrade gems * build(deps): Remove obsolete gems * v0.0.0 * build(deps): Update semantic-release * feat(events): add upcoming events page made a page to to view upcoming events in the management tools * feat(events): added page to make new events * added gem.lock * functionally complete calendar calendar has all the features needed need to make it less janky and possible add/remove features based on feedback * feat(events):page to view and make upcoming events created a page to view, make, and delete events. These events contain a title, description, location, owner(s), if it is a public and/or all day event and when it starts and stops. * fix: corrected formating errors and removed all day option made the code comply with houndci-bot requests and removed the all day bool for a event * fix: removed left over allDay refernce * fix: corrected houndci format suggestion * feat(event): added owners as a list of admins only implemented owners in a similar way to message recipients it will only allow for the selection of admin user as the owner(s) of a event. No owners it also allowed. * fix(events): refactored to work with latest 2.0 altered new manage sidebar to include events and fixed bug in event model testing * Fixed issue on desktop * feat(event): removed unneeded form options removed owner and public options from event creation form since they are no longer relevent for the intended purpose of this schedule * Map overflow scroll Signed-off-by: Peter Kos <[email protected]> * Fix scroll issue Signed-off-by: Peter Kos <[email protected]> * Fixed toggle button; fits screen, sidebar width Sidebar width is better Toggle button fills height of navbar Signed-off-by: Peter Kos <[email protected]> * fix: Allows optional assets to be unset * fix(events):added basic testing added the basic tests and renamed "end" to "finish" in event * Fixes test * fix(event): tweak test in attempt to get working * fix(event): got testing to work for some reason there is a flow for how redirects works for a controller. The index goes to the correct redirect but the create does not. * fix(event): fix hound errors and db password error accidently pushed local db password and corrected hound errors * fix(event): fix houndci error i missed * feat: Redesigns OAuth2 portal (#404) * feat: Redesigns OAuth2 portal * fix: Some Hound issues * Changes application verbiage * Fixes ID issue * Fixes table link and sign out button * Peter's wishes * Adds Redis dump files to .gitignore * fix(event): fixed some of the pull request suggestions * Shorten form :) Signed-off-by: Peter Kos <[email protected]> * fix(forms): change size of all forms without textbox changed the style of all forms that don't have a large text area or other aspects of the form that make a full length form perferable. With the exception of those forms all forms are now more narrow * fix(event): implemented pull request changes fixed cancel button and removed blue dot in list. decided to use simple form datetime picker instead of html datetime-local input because firefox does not support it. * fix: Fixes MyMLH branding in config (#412) * feat(settings): Simplifies Config (#409) * feat(settings): Simplifies Config * Resolves Hound issues * Update app/views/manage/configs/index.html.haml Co-authored-by: Peter Kos <[email protected]> * design: Increases the font-weight and reorganizes the page * fix: Hound issues Co-authored-by: Peter Kos <[email protected]> * feat: Adds support for digital-only hackathons (#395) * feat: Adds support for digital-only hackathons * fix: Provides clarity for what is removed from digital hackathons Co-authored-by: Peter Kos <[email protected]> * event(fix): renamed events to schedule and reverted forms change event to schedule on the mangage sidebar and undid change to forms * feat: Adds GitHub Action for releases (#426) * feat: Adds GitHub Action CI testing (#423) * feat: Adds GitHub Action CI testing * fix: Adds sudo * refactor: Changes naming * Removes travis.yml * docs: Adds ruby version comment * fix(event): schedule now shows end time do to issues with "end" being a keyword in rails and what fullcalendar uses for events ending end time was previously not showing up * fix(event): fix houndci complaints * bundle install * fixed styling errors and added check for finish and start time * made finish time optional and made css fixes * fix houndci complaint * fix houndci complaint part 2 * removed finish time requirement in test Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: Peter Kos <[email protected]> * fix(sidebar): side bar title now matches sidebar width (#537) * side bar title now matches sidebar width * made sidebar narrower Co-authored-by: Peter Kos <[email protected]> * feature: Allows directors to change user's names (#530) * refactor: Changes register to "Create an Account" (#541) * security: Adds rel="noopener" to all target="_blank" (#494) * security: Adds rel="noopener" to all target="_blank" * feature: Adds additonal rel="noopener" Co-authored-by: Peter Kos <[email protected]> * refactor(Users): Shows user's name on show/edit pages (#483) Co-authored-by: Peter Kos <[email protected]> * fix: Questionnaire agreement read and accept error placement (#525) Co-authored-by: Chris Baudouin, Jr <[email protected]> * fix(agreements): decreased distance between icons (#542) Co-authored-by: Chris Baudouin, Jr <[email protected]> * feat(map): Hides map on mobile and added button to show it (#538) * hide map on mobile and added button to show it * map button text now changes when map is open * fix houndci errors Co-authored-by: Chris Baudouin, Jr <[email protected]> * build(deps): Updates shoulda and shoulda-matchers (#482) * master <- develop (2.1.2) (#472) (#478) * fix(questionnaire): missing information now in correct place (#443) * fix(questionnair): missing information now in correct place it now displays the correct message "Please read & accept" instead of missing information and the notification is now in the correct place * Update app/assets/javascripts/validate.js * Revert "Update app/assets/javascripts/validate.js" This reverts commit bc54783. Signed-off-by: Peter Kos <[email protected]> Co-authored-by: Peter Kos <[email protected]> * fix: Fixes mobile agreements layout bug Signed-off-by: Peter Kos <[email protected]> * feat: Removes semantic-release (#446) * refactor: Moves CI to develop branch (#449) Co-authored-by: Peter Kos <[email protected]> * build: Merges 2.1.2 into develop * fix(hakiri): corrected unescaped model attribute * fix(hakiri): added html_safe to show proper output Co-authored-by: Jeremy Rudman <[email protected]> Co-authored-by: JeremyRudman <[email protected]> * fix: Shows questionnaires_closed_message on registration * feat: Allows agreements to be fully customizable (#465) * feat: Allows agreements to be fully customizable * fix: Fixes broken migrations * fix: Migrations misname issue * feat: Forces agreement links to open in new tab * Agreement validation detection fixed Signed-off-by: Peter Kos <[email protected]> * refactor: Removes old input hint Co-authored-by: Peter Kos <[email protected]> * fix(hakiri): fixed un-escaped regex for vcs link (#467) * fix(hakiri): corrected unescaped model attribute * fix(hakiri): added html_safe to show proper output * fix(hakiri): added \A \z to regex * fix(questionnaire): fixed hakiri error with vcs link regex * fix(questionnaire): fixed houndci commplaint Co-authored-by: Chris Baudouin, Jr <[email protected]> * fix(hakiri): fix hakiri error with user input in html_safe (#475) Co-authored-by: Peter Kos <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: Jeremy Rudman <[email protected]> Co-authored-by: Peter Kos <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: Jeremy Rudman <[email protected]> * build(deps): Updates shoulda and shoulda-matchers * Update test/test_helper.rb Co-authored-by: Hound <[email protected]> Co-authored-by: Peter Kos <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: Jeremy Rudman <[email protected]> Co-authored-by: Hound <[email protected]> * refactor: Hides several dangling dietary restrictions in digital mode (#533) * refactor: Hides several dangling dietary restrictions in digital mode * fix: Hides dietary restrictions form questionnaire overview Co-authored-by: JeremyRudman <[email protected]> * fix: Fixes white space next to sidebar (#544) Co-authored-by: Chris Baudouin, Jr <[email protected]> * feat(schedule): add category field to schedule (#546) * feat(schedule): add category field to schedule * moved event catorgory addition to a seprate migration * add category and location label for schedule display * made label more semantically nice * more code cleanup for events * Update app/assets/javascripts/events.js Co-authored-by: Peter Kos <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: Peter Kos <[email protected]> * fix(events): fixed api to be public and have blank strings be null (#552) * fix(events): fixed api to be public and have blank strings be null * made is so category is null on empty string * build: Moves dependabot to develop branch (#507) * build(deps): Updates Sidekiq to 6.1.3 (#461) * build(deps): Updates Sidekiq to 6.1.2 * build: Updates Sidekiq to 6.1.3 * build: Updates sidekiq-cron * refactor: Removes MLH branding from Stats page, moved stats strings to locales (#460) * refactor: Removes MLH branding from Stats page * fix: Updates stats test paths * refactor: Renames several stats tables Co-authored-by: JeremyRudman <[email protected]> * fix: Fixes RSVP Reminder email being sent to RSVP attendees (#557) * fix: Add CORS for all API requests (#554) * cors * Do it more properly * hound * cors allowed only on non-manage routes * Resource path does not support regex; even tonly * only allow on gets lol Co-authored-by: JeremyRudman <[email protected]> * feat(questionnaire): add country field for questionnaire (#550) * feat(questionnaire): add country field for questionnaire the application now asks for a country to due to MLH requirements * fix houndci complaints * Update app/views/application/_missing_country_notice.html.haml Co-authored-by: Chris Baudouin, Jr. <[email protected]> * added custom error message for missing country for RSVP * fix houndci complaints * Update _missing_country_notice.html.haml Co-authored-by: Chris Baudouin, Jr. <[email protected]> Co-authored-by: Peter Kos <[email protected]> * refactor: defined roles do in role selection and refactored readme (#556) * refactor: defined roles do in role selection and refactored readme * Update README.md Co-authored-by: Peter Kos <[email protected]> * completed questionnaire page on docs (#512) * completed questionnaire page on docs * Update questionnaires.md * Fix various typos Co-authored-by: Peter Kos <[email protected]> Co-authored-by: JeremyRudman <[email protected]> * feature: Allows directors to reset passwords through admin portal (#524) Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: Peter Kos <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: Jeremy Rudman <[email protected]> Co-authored-by: Hound <[email protected]> Co-authored-by: aag5734 <[email protected]>

cbaudouinjr and others added 11 commits May 6, 2020 18:23

build(deps): Upgrade yarn

8ccbb2f

build(deps): Upgrade gems

38a605c

build(deps): Remove obsolete gems

b19aa4f

v0.0.0

87f4245

build(deps): Update semantic-release

3543164

feat(events): add upcoming events page

dfc116f

made a page to to view upcoming events in the management tools

feat(events): added page to make new events

f3e659d

added gem.lock

e3f9c4f

Merge branch '2.0' into issue-226

6539671

functionally complete calendar

c7de97f

calendar has all the features needed need to make it less janky and possible add/remove features based on feedback

feat(events):page to view and make upcoming events

ca0248b

created a page to view, make, and delete events. These events contain a title, description, location, owner(s), if it is a public and/or all day event and when it starts and stops.

houndci-bot reviewed Jun 13, 2020

View reviewed changes

Merge branch '2.0' into issue-226

fc7f106

houndci-bot reviewed Jun 13, 2020

View reviewed changes

app/assets/javascripts/events.js Outdated Show resolved Hide resolved

app/assets/javascripts/events.js Outdated Show resolved Hide resolved

cbaudouinjr self-requested a review June 28, 2020 04:22

JeremyRudman added 2 commits July 3, 2020 15:36

Merge branch '2.0' into issue-226

6706ee2

fix: corrected formating errors and removed all day option

6cf5144

made the code comply with houndci-bot requests and removed the all day bool for a event

houndci-bot reviewed Jul 4, 2020

View reviewed changes

app/controllers/manage/events_controller.rb Outdated Show resolved Hide resolved

JeremyRudman and others added 3 commits July 4, 2020 05:35

fix: removed left over allDay refernce

1520b42

fix: corrected houndci format suggestion

122c209

Merge branch '2.0' into issue-226

ac9e1db

JeremyRudman added 2.0 API high priority labels Aug 1, 2020

JeremyRudman added 2 commits August 10, 2020 04:27

feat(event): added owners as a list of admins only

c6caf7a

implemented owners in a similar way to message recipients it will only allow for the selection of admin user as the owner(s) of a event. No owners it also allowed.

Merge branch 'issue-226' of https://github.com/codeRIT/hackathon-manager

826540f

into issue-226

JeremyRudman added the blocked label Aug 10, 2020

cbaudouinjr linked an issue Aug 16, 2020 that may be closed by this pull request

Build hackathon schedule into HM #226

Closed

1 task

Merge branch '2.0' into issue-226

3618cdd

JeremyRudman added 2.1.2 and removed 2.2 the next rodeo labels Dec 16, 2020

Merge branch '2.1.2' into issue-226

6c37465

JeremyRudman added 2.2 the next rodeo and removed 2.1.2 labels Dec 18, 2020

Base automatically changed from 2.1.2 to develop December 18, 2020 05:57

peterkos assigned JeremyRudman Dec 22, 2020

peterkos changed the base branch from develop to 2.2 January 3, 2021 02:04

peterkos and others added 3 commits January 2, 2021 21:09

Merge branch '2.2' into issue-226

1844eae

# Conflicts: # Gemfile.lock

bundle install

bd88847

Merge branch '2.2' into issue-226

a12dc7d

peterkos requested changes Jan 17, 2021

View reviewed changes

Merge branch '2.2' into issue-226

b57fc75

JeremyRudman added 2 commits January 23, 2021 02:05

fixed styling errors and added check for finish and start time

6abb189

Merge branch 'issue-226' of https://github.com/codeRIT/hackathon-manager

f8c3141

into issue-226

houndci-bot reviewed Jan 23, 2021

View reviewed changes

app/assets/javascripts/events.js Outdated Show resolved Hide resolved

app/assets/javascripts/events.js Outdated Show resolved Hide resolved

made finish time optional and made css fixes

690d60c

houndci-bot reviewed Jan 23, 2021

View reviewed changes

app/models/event.rb Outdated Show resolved Hide resolved

fix houndci complaint

d61c80f

houndci-bot reviewed Jan 23, 2021

View reviewed changes

app/models/event.rb Outdated Show resolved Hide resolved

fix houndci complaint part 2

8f90285

JeremyRudman requested a review from peterkos January 23, 2021 09:22

removed finish time requirement in test

8b75e16

peterkos approved these changes Jan 23, 2021

View reviewed changes

peterkos requested a review from cbaudouinjr January 23, 2021 21:01

cbaudouinjr approved these changes Jan 23, 2021

View reviewed changes

cbaudouinjr merged commit 573fe45 into 2.2 Jan 23, 2021

cbaudouinjr deleted the issue-226 branch January 23, 2021 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Adds event calendar support #259

feat: Adds event calendar support #259

Uh oh!

JeremyRudman commented Jun 13, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeremyRudman commented Aug 10, 2020 •

edited

Loading

Uh oh!

peterkos left a comment •

edited by JeremyRudman

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeremyRudman commented Jan 23, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: Adds event calendar support #259

feat: Adds event calendar support #259

Uh oh!

Conversation

JeremyRudman commented Jun 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeremyRudman commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterkos left a comment • edited by JeremyRudman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeremyRudman commented Jan 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeremyRudman commented Jun 13, 2020 •

edited

Loading

JeremyRudman commented Aug 10, 2020 •

edited

Loading

peterkos left a comment •

edited by JeremyRudman

Loading

JeremyRudman commented Jan 23, 2021 •

edited

Loading