crdb-release-22.2: Move from StatePause->StateReplicate on heartbeat response when possible #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of `go mod tidy`.
It will be touched in this PR. Signed-off-by: Tobias Grieger <[email protected]>
After a call to `ReportUnreachable`, a fully caught up follower would end up in StateReplicate and not leave it despite responding to heartbeats. This is a bug which is going to be fixed in a follow-up commit. Signed-off-by: Tobias Grieger <[email protected]>
See individual commits. Essentially, when a fully caught-up follower was reported unreachable, it'd transition to `StateProbe` but then wouldn't recover from that via heartbeats (once they resumed). This caused some issues in CRDB because we rely on the reported status to reason about the safety of leadership changes, etc. This PR makes it such that StateProbe resolves on its own: when the leader hears back from the follower via a heartbeat, it sends an empty MsgApp, and as response to this moves the follower back into StateProbe. Signed-off-by: Tobias Grieger <[email protected]>
erikgrinaker
changed the title
tbg
approved these changes
Jul 7, 2023
Member
tbg
left a comment
tbg
left a comment
There was a problem hiding this comment.
Any trouble merging this in? Have not reviewed in depth.
Author
|
Just annoying since I couldn't get git am to apply the patch properly from the raft repo. Basically had to apply it manually. But otherwise good, tests are passing. Wonder if there could be any unexpected interactions due to other patches that we've skipped, but this seems reasonable on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports etcd-io/raft#52 on behalf of @tbg.
Move from StatePause->StateReplicate on heartbeat response when possible
See individual commits. Essentially, when a fully caught-up follower was
reported unreachable, it'd transition to
StateProbebut then wouldn'trecover from that via heartbeats (once they resumed).
This caused some issues in CRDB because we rely on the reported status
to reason about the safety of leadership changes, etc.
This PR makes it such that StateProbe resolves on its own: when the
leader hears back from the follower via a heartbeat, it sends an
empty MsgApp, and as response to this moves the follower back into
StateProbe.
Touches cockroachdb/cockroach#104304.
Touches cockroachdb/cockroach#101624.
Signed-off-by: Tobias Grieger [email protected]