rpc: remove noisy neighbor test #118310
Merged
rpc: remove noisy neighbor test #118310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
nvb
approved these changes
Jan 25, 2024
The test TestHeartbeatHealthTransport frequently fails due to cross-talk between different tests on the same node. There is better protection in the most recent code, but it is easiest just to delete this test in 22.2 as it has minimal use. Epic: none Fixes: cockroachdb#117766 Release note: None
kvoli
force-pushed
the
240125.remove-test-heartbeat-health-transport
branch
from
9f3fb93 to
9010566
Compare
Contributor
Author
|
TYFTR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test TestHeartbeatHealthTransport frequently fails due to cross-talk between different tests on the same node. There is better protection in the most recent code, but it is easiest just to delete this test in 22.2 as it has minimal use.
Note this test was removed from 23.2 onward in #99191 and removed from 22.2 in #110384. This PR removes it from 23.1.
Epic: none
Fixes: #117766
Release note: None