kvprober: remove unnecessary checks to avoid flakes #108108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes two unnecessary checks, to avoid flakes. The removed checks can cause flakes, since they require all probes (of a certain type) to fail, even tho the test server is not configured to fail probes until after server startup. That is, there is a race condition. The checks are also unnecessary. What we really care about is the checks that follow the deleted ones: That the ten probes run within test all fail, since those happen after the test server is configured to fail probes. Release note: None. Epic: None.
Member
|
This change is |
pav-kv
approved these changes
Aug 3, 2023
Collaborator
pav-kv
left a comment
pav-kv
left a comment
There was a problem hiding this comment.
Does this need backporting, in case this flakes in other branches?
Collaborator
Author
|
I don't believe so. The test refactor made in #104365 is only in master, and I believe it lead to these flakes. If you want details, let me know, and I will elaborate. The TLDR is we are now using the server's prober rather than a separate one created within the test. I think it's a good change, but it requires adjustments to the checks, as made in this PR. |
Collaborator
Author
|
TFTR! |
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107873.
kvprober: remove unnecessary checks to avoid flakes
This commit removes two unnecessary checks, to avoid flakes. The removed checks can cause flakes, since they require all probes (of a certain type) to fail, even tho the test server is not configured to fail probes until after server startup. That is, there is a race condition. The checks are also unnecessary. What we really care about is the checks that follow the deleted ones: That the ten probes run within test all fail, since those happen after the test server is configured to fail probes.
Release note: None.
Epic: None.