copy: fix nil pointer in COPY telemetry logging #103738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
added
the
backport-23.1.x
Member
|
This change is |
rafiss
force-pushed
the
fix-copy-log-panic
branch
from
7a63a3a to
3341b5a
Compare
otan
approved these changes
May 23, 2023
otan
reviewed
May 23, 2023
| initPlanner: func(ctx context.Context, p *planner) { | ||
| ex.initPlanner(ctx, p) | ||
| }, | ||
| resetPlanner: func(ctx context.Context, p *planner, txn *kv.Txn, txnTS time.Time, stmtTS time.Time) { |
Contributor
There was a problem hiding this comment.
should we delete resetPlanner from the copyTxnOpt struct too?
Collaborator
Author
There was a problem hiding this comment.
oops my fix is invalid. i forgot about the mode where we batch copies and call this resetPlanner in between each batch.
rafiss
force-pushed
the
fix-copy-log-panic
branch
from
3341b5a to
7c70f57
Compare
rafiss
force-pushed
the
fix-copy-log-panic
branch
from
7c70f57 to
542028c
Compare
Release note (bug fix): Fixed a panic that could occur while a COPY statement is logged for telemetry purposes.
rafiss
force-pushed
the
fix-copy-log-panic
branch
from
542028c to
307b038
Compare
Collaborator
Author
|
went with a more basic fix. please take another look! |
otan
approved these changes
May 24, 2023
Collaborator
Author
|
tftr! bors r+ |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #102494
Release note (bug fix): Fixed a panic that could occur while a COPY statement is logged for telemetry purposes.