server: call VerifyClockOffset directly #103582
Merged
+20
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was this weird setup where we were hiding it in a callback. Let's just call it directly. This was masking that fatalling on the result is actually turned off except when starting a `Server` (i.e. outside of pure unit tests). Now there's an explicit variable on the options to opt into the fatal error. Now we also call it only when we want to: we didn't actually want to call it when dealing with blocking requests. It didn't hurt either since the blocking requests didn't change the state of the tracker, but still - now we're only checking when something has changed which is better. Epic: None Release note: None
Member
|
This change is |
aliher1911
approved these changes
May 19, 2023
Contributor
aliher1911
left a comment
aliher1911
left a comment
There was a problem hiding this comment.
I think fatalling in callback makes sense if you treat rpc context as a library. You don't necessarily want library to terminate your process. But in this case it is sufficiently embedded with the rest of server and we also do it throughout the code.
Member
Author
|
Thanks Oleg! bors r=aliher1911 |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #99191.
There was this weird setup where we were hiding it in a callback.
Let's just call it directly.
This was masking that fatalling on the result is actually turned off except
when starting a
Server(i.e. outside of pure unit tests). Now there'san explicit variable on the options to opt into the fatal error.
Now we also call it only when we want to: we didn't actually want to call it
when dealing with blocking requests. It didn't hurt either since the blocking
requests didn't change the state of the tracker, but still - now we're only
checking when something has changed which is better.
Epic: None
Release note: None