Skip to content

Call tool missing arguments crashes server #209

@feng19

Description

@feng19

Call tool missing arguments crashes server

21:00:16.988 [debug] MCP transport details: %{message: %{"id" => 10, "jsonrpc" => "2.0", "method" => "tools/call", "params" => %{"name" => "document_xxx"}}, session_id: "session_GFUxO1RGSRN33443JQc="}
21:00:16.988 [debug] MCP server event: handling_request
21:00:16.988 [debug] MCP event details: %{id: 10, method: "tools/call"}
21:00:16.989 [debug] MCP server event: terminating
21:00:16.992 [debug] MCP event details: %{reason: {:function_clause, [{Hermes.Server.Handlers.Tools, :handle_call, [%{"id" => 10, "jsonrpc" => "2.0", "method" => "tools/call", "params" => %{"name" => "document_xxx"}}, #Frame<[session_id: "session_GFUxO1RGSRN33443JQc=", request: "tools/call", assigns: %{}, initialized: true, tools: 0, resources: 0, prompts: 0]>, BookMcp.MCPServer], [file: ~c"lib/hermes/server/handlers/tools.ex", line: 27]}, {Hermes.Server.Base, :server_request, 2, [file: ~c"lib/hermes/server/base.ex", line: 503]}, {Hermes.Server.Base, :handle_call, 3, [file: ~c"lib/hermes/server/base.ex", line: 115]}, {:gen_server, :try_handle_call, 4, [file: ~c"gen_server.erl", line: 2381]}, {:gen_server, :handle_msg, 6, [file: ~c"gen_server.erl", line: 2410]}, {:proc_lib, :wake_up, 3, [file: ~c"proc_lib.erl", line: 340]}]}, server_info: %{"name" => "Intrivo Telehealth", "version" => "1.0.0"}}
21:00:16.994 [error] GenServer {Hermes.Server.Registry, {:server, BookMcp.MCPServer}} terminating
** (FunctionClauseError) no function clause matching in Hermes.Server.Handlers.Tools.handle_call/3
    (hermes_mcp 0.13.0) lib/hermes/server/handlers/tools.ex:27: Hermes.Server.Handlers.Tools.handle_call(%{"id" => 10, "jsonrpc" => "2.0", "method" => "tools/call", "params" => %{"name" => "document_xxx"}}, #Frame<[session_id: "session_GFUxO1RGSRN33443JQc=", request: "tools/call", assigns: %{}, initialized: true, tools: 0, resources: 0, prompts: 0]>, BookMcp.MCPServer)

It is expected to return an error and should not crash the server.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions