Skip to content

Conversation

@abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Oct 29, 2025

Description

  • sources check (if no sources then initiate orphan resource deletion) early exit
  • validate sources (early exit)
  • initiate orphan resource deletion (if any) (exit on error)

This PR ensures that the above reconciling functionalities should preserve their errors, messages and reasons when encountered and not be replaced by the generic "not all catalog objects are ready"

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan changed the title fix(catalogs): update reconcile ordering and set various not ready reasons fix(catalogs): update reconcile ordering and preserve validation failed conditions Oct 29, 2025
@abhijith-darshan abhijith-darshan marked this pull request as ready for review October 29, 2025 14:00
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner October 29, 2025 14:00
IvoGoman
IvoGoman previously approved these changes Oct 29, 2025
Signed-off-by: abhijith-darshan <[email protected]>

(chore): fix tests

Signed-off-by: abhijith-darshan <[email protected]>
@IvoGoman IvoGoman merged commit a113a4b into main Oct 29, 2025
21 checks passed
@IvoGoman IvoGoman deleted the fix/catalog_status_clean branch October 29, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants