Skip to content

feat(catalogs): adds labels to resources of catalog #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhijith-darshan merged 1 commit into from
Oct 28, 2025
Merged

feat(catalogs): adds labels to resources of catalog #1575

abhijith-darshan merged 1 commit into from
Oct 28, 2025
+17 −4

Conversation

@abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Oct 28, 2025 •
edited
Loading

Description

Apply labels to resources of Catalog object (PluginDefinitions || ClusterPluginDefinitions)

apiVersion: greenhouse.sap/v1alpha1
kind: PluginDefinition
metadata:
  greenhouse.sap/catalog: <catalog-name>
  greenhouse.sap/catalog-source: repository-<hash>
....

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan marked this pull request as ready for review October 28, 2025 12:53
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner October 28, 2025 12:53
@abhijith-darshan
(chore): adds catalog labels to resources applied by catalog
de60e19 
Signed-off-by: abhijith-darshan <[email protected]>

(chore): remove catalog namespace label

Signed-off-by: abhijith-darshan <[email protected]>
@abhijith-darshan abhijith-darshan self-assigned this Oct 28, 2025
@abhijith-darshan abhijith-darshan merged commit 52de99f into main Oct 28, 2025
20 checks passed
@abhijith-darshan abhijith-darshan deleted the feat/catalog_labels branch October 28, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uwe-mayer uwe-mayer uwe-mayer approved these changes

Assignees

@abhijith-darshan abhijith-darshan

Labels

core-apis feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abhijith-darshan @uwe-mayer