feat(catalogs): multi-source catalog #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
core-apis
helm-charts
dependencies
documentation
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
77634db to
c1578c7
Compare
24 tasks
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
bd8f199 to
4dd16c3
Compare
abhijith-darshan
changed the title
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
2a03db7 to
9091ce9
Compare
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
9091ce9 to
97c0295
Compare
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
2 times, most recently
from
de0214d to
4611e21
Compare
IvoGoman
reviewed
Oct 23, 2025
Contributor
IvoGoman
left a comment
IvoGoman
left a comment
There was a problem hiding this comment.
Good stuff. Still need to go through the controller code. Most of the comments are doc related or smaller things.
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
3 times, most recently
from
3a7d644 to
7a640c8
Compare
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
91d4812 to
5ec6e8a
Compare
IvoGoman
reviewed
Oct 24, 2025
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
e929123 to
8250433
Compare
IvoGoman
previously approved these changes
Oct 27, 2025
updates catalog API (Breaking change) Signed-off-by: abhijith-darshan <[email protected]> (chore): register artifact generator scheme Signed-off-by: abhijith-darshan <[email protected]> (chore): removes kustomize WithPath option Signed-off-by: abhijith-darshan <[email protected]> (chore): adds involved object creation files Signed-off-by: abhijith-darshan <[email protected]> (chore): updates catalog controller removes secret watch and secret managed label adds custom predicate to ignore reconciliation if status hasn't changed sets conditions for involved objects Signed-off-by: abhijith-darshan <[email protected]> (chore): updates env tests Signed-off-by: abhijith-darshan <[email protected]> (chore): updates e2e tests Signed-off-by: abhijith-darshan <[email protected]> (chore): updates local env flux setup installs source-watcher for artifact generator extension adds feature gates to enable ExternalArtifact on kustomize controller Signed-off-by: abhijith-darshan <[email protected]> (chore): adds helper func Signed-off-by: abhijith-darshan <[email protected]> (chore): adds ignore status update predicate generic ignore status predicate for flux and greenhouse objects Signed-off-by: abhijith-darshan <[email protected]> (chore): array of sources in catalog spec Signed-off-by: abhijith-darshan <[email protected]> (chore): generate manifests Signed-off-by: abhijith-darshan <[email protected]> (chore): adds label keys for catalog Signed-off-by: abhijith-darshan <[email protected]> (chore): adds source generator for Catalog Signed-off-by: abhijith-darshan <[email protected]> (chore): update controller to handle multiple sources create multiple internal catalog resources to resolve greenhouse objects from Git repo handles deletion of orphaned internal catalog resources Signed-off-by: abhijith-darshan <[email protected]> (chore): updates tests Signed-off-by: abhijith-darshan <[email protected]> (chore): tidy up Signed-off-by: abhijith-darshan <[email protected]> (chore): update sample with multi-source Signed-off-by: abhijith-darshan <[email protected]> Automatic generation of CRD API Docs (chore): remove scoped test Signed-off-by: abhijith-darshan <[email protected]> (chore): use hash/fnv instead of crypto/md5 Signed-off-by: abhijith-darshan <[email protected]> Automatic generation of CRD API Docs (chore): fix lint err Signed-off-by: abhijith-darshan <[email protected]> (chore): use strconv FormatUint instead of fmt.Sprintf Signed-off-by: abhijith-darshan <[email protected]> (chore): return on err Signed-off-by: abhijith-darshan <[email protected]> (chore): update test Signed-off-by: abhijith-darshan <[email protected]> (chore): err checks in unit tests Signed-off-by: abhijith-darshan <[email protected]> (chore): use net/url Signed-off-by: abhijith-darshan <[email protected]> (chore): apply code suggestions from review Co-authored-by: IvoGoman <[email protected]> (chore): add api docs Signed-off-by: abhijith-darshan <[email protected]> (chore): remove common labels Signed-off-by: abhijith-darshan <[email protected]> (chore): remove TODO Signed-off-by: abhijith-darshan <[email protected]> (chore): regenerate manifests Signed-off-by: abhijith-darshan <[email protected]> Automatic generation of CRD API Docs (chore): refactor status inventory sourceErr type to return source object errors used to set inventory errors Signed-off-by: abhijith-darshan <[email protected]> (chore): removes lifecycle.predicates Signed-off-by: abhijith-darshan <[email protected]> (chore): incrementally remove items from inventory[hash] during orphaned resource deletion, incrementally remove items in hash to reflect the status in case of error deleting orphaned resources. Signed-off-by: abhijith-darshan <[email protected]> (chore): generate api docs Signed-off-by: abhijith-darshan <[email protected]> (chore): fix lint errs and remove status.inventory[hash] entries if len of items of hash is empty Signed-off-by: abhijith-darshan <[email protected]>
abhijith-darshan
force-pushed
the
feat/catalog_sources
branch
from
8250433 to
6b81951
Compare
IvoGoman
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catalog can resolve resources from multiple sources
(Currently targeting multiple GitHub sources)
internally Catalog utilizes, flux
AritfactGeneratorto generate ExternalArtifact, which is consumed byKustomizationWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Test to confirm ArtifactGenerator and ExternalArtifact applies
(Cluster)PluginDefinitionsAdded to documentation?
Checklist