Skip to content

Conversation

@Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Oct 9, 2025

Description

Move PluginDefinitionRef Kind defaulting to the mutating webhooks, because the mutating webhook executes before CRD defaulting.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 requested a review from a team as a code owner October 9, 2025 09:27
@Zaggy21 Zaggy21 linked an issue Oct 9, 2025 that may be closed by this pull request
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 9, 2025
@IvoGoman IvoGoman merged commit 33dce43 into main Oct 9, 2025
30 checks passed
@IvoGoman IvoGoman deleted the fix/defaulting-plugindefinitionref-kind branch October 9, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-apis documentation Improvements or additions to documentation helm-charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Defaulting of .spec.pluginDefintionRef.kind broken

3 participants