Skip to content

Conversation

@mikolajkucinski
Copy link
Contributor

@mikolajkucinski mikolajkucinski commented Oct 8, 2025

Description

Implement RBAC permissions for Catalog ServiceAccount to manage PluginDefinitions.

Regular organizations:

  • Role + RoleBinding for PluginDefinitions in their own namespace only

Greenhouse organization:

  • ClusterRole + ClusterRoleBinding for both PluginDefinitions (cluster-wide) and ClusterPluginDefinitions

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@mikolajkucinski mikolajkucinski changed the title feat(catalog): implement Role and RoleBinding for catalog SA feat(catalogs): implement Role and RoleBinding for catalog SA Oct 8, 2025
@mikolajkucinski mikolajkucinski force-pushed the feat/catalog-plugindefinition-rolebinding branch from 6b6f668 to e32e6b3 Compare October 9, 2025 08:31
@mikolajkucinski mikolajkucinski marked this pull request as ready for review October 9, 2025 08:38
@mikolajkucinski mikolajkucinski requested a review from a team as a code owner October 9, 2025 08:38
@mikolajkucinski mikolajkucinski force-pushed the feat/catalog-plugindefinition-rolebinding branch 2 times, most recently from 6099094 to 338d0c5 Compare October 9, 2025 08:43
@mikolajkucinski mikolajkucinski force-pushed the feat/catalog-plugindefinition-rolebinding branch from 338d0c5 to dd5916b Compare October 9, 2025 09:58
@mikolajkucinski mikolajkucinski merged commit 70f8421 into main Oct 9, 2025
27 checks passed
@mikolajkucinski mikolajkucinski deleted the feat/catalog-plugindefinition-rolebinding branch October 9, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] - Creation of ServiceAccount for Org to handle Catalogs

3 participants