generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(pluginpresets): specify and propagate plugin dependencies via waitFor #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
IvoGoman
reviewed
Oct 7, 2025
On-behalf-of: @SAP [email protected]
… field set On-behalf-of: @SAP [email protected]
…lease dependencies, update tests On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
IvoGoman
requested changes
Oct 21, 2025
On-behalf-of: @SAP [email protected]
IvoGoman
previously approved these changes
Oct 21, 2025
…inPreset dependencies On-behalf-of: @SAP [email protected]
IvoGoman
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a list of PluginRefs into .spec.waitFor in PluginPresets and Plugins. Plugin dependencies are verified on the HelmRelease level. Webhooks validate that each PluginRef has only one value set: Name or PluginPreset. PluginPresetController copies over all PluginRefs in PluginPresets to Plugin's waitFor. Then Flux PluginController resolves the dependencies by transforming PluginRefs so that only Plugin names are set and sets them on spec.dependsOn in the HelmRelease for the Plugin (because plugin name equals helm release name).
This PR also introduces a new status condition on Plugins: WaitingForDependencies condition. The message about not ready dependencies is propagated from flux into the condition.
What type of PR is this? (check all applicable)
Related Tickets & Documents
.spec.waitFor#1420.spec.waitForfrom PluginPreset to Plugin #1422Added tests?
Added E2E test that checks that WaitFor is propagated and the Flux waits for dependent HelmRelease to be installed first.
Added to documentation?
Checklist