Skip to content

Conversation

@Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Oct 6, 2025

Description

This PR adds a list of PluginRefs into .spec.waitFor in PluginPresets and Plugins. Plugin dependencies are verified on the HelmRelease level. Webhooks validate that each PluginRef has only one value set: Name or PluginPreset. PluginPresetController copies over all PluginRefs in PluginPresets to Plugin's waitFor. Then Flux PluginController resolves the dependencies by transforming PluginRefs so that only Plugin names are set and sets them on spec.dependsOn in the HelmRelease for the Plugin (because plugin name equals helm release name).
This PR also introduces a new status condition on Plugins: WaitingForDependencies condition. The message about not ready dependencies is propagated from flux into the condition.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added E2E test that checks that WaitFor is propagated and the Flux waits for dependent HelmRelease to be installed first.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 linked an issue Oct 6, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 7, 2025
@Zaggy21 Zaggy21 marked this pull request as ready for review October 7, 2025 00:19
@Zaggy21 Zaggy21 requested a review from a team as a code owner October 7, 2025 00:19
IvoGoman
IvoGoman previously approved these changes Oct 21, 2025
@Zaggy21 Zaggy21 merged commit 8e52b65 into main Oct 22, 2025
23 checks passed
@Zaggy21 Zaggy21 deleted the feat/pluginpreset-plugin-specify-specwaitfor branch October 22, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-apis documentation Improvements or additions to documentation feature helm-charts

Projects

None yet

3 participants