Skip to content

fix(plugins): skip releaseName validation for UI Plugins #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhijith-darshan merged 2 commits into from
Oct 1, 2025
Merged

fix(plugins): skip releaseName validation for UI Plugins #1423

abhijith-darshan merged 2 commits into from
Oct 1, 2025

Conversation

@abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Sep 24, 2025 •
edited
Loading

Description

Skip releaseName validation for UI plugins

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan self-assigned this Sep 24, 2025
@abhijith-darshan abhijith-darshan marked this pull request as ready for review September 24, 2025 13:54
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner September 24, 2025 13:54
IvoGoman
IvoGoman reviewed Sep 24, 2025
View reviewed changes
@abhijith-darshan abhijith-darshan force-pushed the fix/plugin_admission branch 2 times, most recently from e112f4b to 7c63be4 Compare October 1, 2025 01:46
@abhijith-darshan
(chore): skip releaseName validation for UI Plugins
8339012 
Signed-off-by: abhijith-darshan <[email protected]>

(chore): skip releaseName defaulting for UI App only if no helmChart

Signed-off-by: abhijith-darshan <[email protected]>

(chore): fix defaulting

Signed-off-by: abhijith-darshan <[email protected]>
@abhijith-darshan abhijith-darshan merged commit 06507f7 into main Oct 1, 2025
27 checks passed
@abhijith-darshan abhijith-darshan deleted the fix/plugin_admission branch October 1, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvoGoman IvoGoman IvoGoman approved these changes

Assignees

@abhijith-darshan abhijith-darshan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abhijith-darshan @IvoGoman