feat(pluginpresets): rename AvailablePlugins to TotalPlugins and add AllPluginsReadyCondition #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolajkucinski
changed the title
github-actions
bot
added
the
documentation
mikolajkucinski
force-pushed
the
feat/plugin-preset-status-improvements
branch
from
e55e79b to
8827620
Compare
Contributor
Author
IvoGoman
reviewed
Aug 25, 2025
IvoGoman
previously approved these changes
Aug 25, 2025
- Rename AvailablePlugins field to TotalPlugins for better clarity - Add AllPluginsReadyCondition to track when all managed plugins are ready On-behalf-of: @SAP [email protected]
- consider AllPluginsReadyCondition while computing Ready status - don't consider PluginSkippedCondition while computing Ready status as it might provide misleading result On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
mikolajkucinski
force-pushed
the
feat/plugin-preset-status-improvements
branch
from
efb8f56 to
06c6945
Compare
On-behalf-of: @SAP [email protected]
IvoGoman
approved these changes
Aug 25, 2025
IvoGoman
pushed a commit
that referenced
this pull request
Aug 25, 2025
…AllPluginsReadyCondition (#1366) * rename AvailablePlugins to TotalPlugins and add AllPluginsReadyCondition - Rename AvailablePlugins field to TotalPlugins for better clarity - Add AllPluginsReadyCondition to track when all managed plugins are ready On-behalf-of: @SAP [email protected] * Automatic generation of CRD API Docs * address review comment - consider AllPluginsReadyCondition while computing Ready status - don't consider PluginSkippedCondition while computing Ready status as it might provide misleading result On-behalf-of: @SAP [email protected] * use different condition message On-behalf-of: @SAP [email protected] * fix linters On-behalf-of: @SAP [email protected] --------- Co-authored-by: cloud-operator-bot[bot] <224791424+cloud-operator-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AvailablePluginsfield toTotalPluginsfor better clarityAllPluginsReadyConditionto track when all managed plugins are readyWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist