generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
fix(clusterkubeconfigs): calculate kubeconfig status #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
reviewed
Aug 25, 2025
IvoGoman
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After an initial reconcile error (e.g., Secret not found), the
ClusterKubeconfigkeepsstatus.conditions[type=ReconcileFailed]=Trueeven after the Secret is created and the cluster becomes ready.Root cause:
calculateKubeconfigStatusderives readiness only from the previous status; ifReconcileFailedis alreadyTrue, it forcesReady=Falseand never clears the failure. It does not re-evaluate the current Spec to see that kubeconfig data is now present.Fix:
Make
calculateKubeconfigStatusinspect the current spec (Clusters,AuthInfo,Contexts+CurrentContext). If these are populated, set:KubeconfigReady=True (reason=Complete)ReconcileFailed=False (reason=ReadyState)KubeconfigCreated=False (reason=ReadyState)This clears the stale failure and reflects the actual, now-healthy state.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist