Skip to content

Conversation

@uwe-mayer
Copy link
Contributor

Description

Currently we disallow any direct Value in OptionValues of type secret. We only allow SecretReferences.
With the introduction of #1211 we will want to allow direct references to secrets stored in vault.

This changes the Admission to allow string values prefixed with

vault+kvv2:///

which is the agreed upon schema to refer to vault entries.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#1211

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@uwe-mayer uwe-mayer requested a review from a team as a code owner August 18, 2025 11:13
Copy link
Contributor

@abhijith-darshan abhijith-darshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@abhijith-darshan abhijith-darshan changed the title feat(webhook): Allow direct vault reference in secret PluginOptionValues feat(webhook): allow direct vault reference in secret PluginOptionValues Aug 18, 2025
@uwe-mayer uwe-mayer merged commit 77c6f17 into main Aug 20, 2025
24 checks passed
@uwe-mayer uwe-mayer deleted the feat/allow-vault-references-in-secret-values branch August 20, 2025 11:45
cloud-operator-bot bot pushed a commit that referenced this pull request Sep 15, 2025
@cloud-operator-bot
Copy link
Contributor

IvoGoman pushed a commit that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants