Inject package version during build instead of importing it from pack… #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
patrick-tolosa
requested changes
Sep 12, 2021
strausr
requested changes
Sep 13, 2021
patrick-tolosa
approved these changes
Sep 13, 2021
strausr
approved these changes
Sep 13, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes end users errors related to importing from package.json file.
The package version is injected during build instead of importing it from package.json.
Also mocked the version value during unit tests, because they rely on source code and not on build result.
I also tested manually by building and looking for the value in the resulted bundle, it was indeed replaced during build.