Skip to content

Conversation

hsinn0
Copy link
Contributor

@hsinn0 hsinn0 commented Aug 19, 2025

…yment

  • Added the code to override default feature flags upon initialization of new deployment.
  • TNZ-48301

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    The objective: Platform engineer can override feature flags in the capi release bosh deployment manifest.

    Manifest example:

  - consumes: {}
    name: cloud_controller_ng
    properties:
      <snip>
      cc:
      <snip>
        feature_flag_overrides:
          diego_docker: true
          route_sharing: true

…yment

- Added the code to override default feature flags upon initialization of new deployment.
- TNZ-48301
@hsinn0 hsinn0 force-pushed the feature_flag_override branch from aab3db3 to b7db2eb Compare August 19, 2025 21:03
@Gerg Gerg self-requested a review August 20, 2025 18:18
@hsinn0 hsinn0 marked this pull request as ready for review August 20, 2025 20:19
Copy link
Member

@Gerg Gerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this PR looks really good.

I left a few comments with code style and error message suggestions. Happy to chat, if you want to go into more detail on any of them.

- Changed the error message for invalid flag names and values to be more specific.
- Changed to do stronger test assertions for error message validations.
@hsinn0 hsinn0 requested a review from Gerg August 27, 2025 00:58
Copy link
Member

@Gerg Gerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@Gerg Gerg merged commit c00ebc1 into cloudfoundry:main Aug 28, 2025
11 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Aug 28, 2025
Changes in cloud_controller_ng:

- feat: Platform Engineer can configure CF feature flags via bosh deplo…
    PR: cloudfoundry/cloud_controller_ng#4523
    Author: Hongchol Sinn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants