-
Notifications
You must be signed in to change notification settings - Fork 365
feat: Platform Engineer can configure CF feature flags via bosh deplo… #4523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
baa7e65
to
aab3db3
Compare
…yment - Added the code to override default feature flags upon initialization of new deployment. - TNZ-48301
aab3db3
to
b7db2eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this PR looks really good.
I left a few comments with code style and error message suggestions. Happy to chat, if you want to go into more detail on any of them.
- Changed the error message for invalid flag names and values to be more specific. - Changed to do stronger test assertions for error message validations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Changes in cloud_controller_ng: - feat: Platform Engineer can configure CF feature flags via bosh deplo… PR: cloudfoundry/cloud_controller_ng#4523 Author: Hongchol Sinn <[email protected]>
…yment
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
The objective: Platform engineer can override feature flags in the capi release bosh deployment manifest.
Manifest example:
An explanation of the use cases your change solves
See the above.
Links to any other associated PRs
feat: Platform Engineer can configure CF feature flags via bosh deplo… capi-release#567
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests